Store file size in normal files, not extended attributes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52: Introduce checks to test if a file is empty.
Extended attributes have caused issues for some users in the past, e.g. #34, #40 and #20. In addition, user extended attributes are not supported by tmpfs, but it would be useful to run our docker integration tests in a tmpfs to avoid lags caused by write-heavy operations (see #27).
Since extended attributes have no important advantages when compared to storing the content length in a normal file, the decision was made to store the content length in a normal file.
This means Flexo now has no special requirements about the file system being used.